Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate compact serialization of Binary, HexBinary, Checksum (backport #2125) #2128

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Deprecate compact serialization of Binary, HexBinary, Checksum (backport #2125) #2128

merged 4 commits into from
Apr 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 25, 2024

This is an automatic backport of pull request #2125 done by [Mergify](https://mergify.com).

@uint @mergify
deprecate compact serialization of some types
7e6ef01 
Binary, HexBinary, Checksum

(cherry picked from commit a49c769)
@mergify mergify bot added the conflicts label Apr 25, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Apr 25, 2024

Cherry-pick of b8da044 has failed:

On branch mergify/bp/release/2.0/pr-2125
Your branch is ahead of 'origin/release/2.0' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit b8da04453.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Apr 25, 2024
Merged
@uint uint changed the title [main] Deprecate compact serialization of Binary, HexBinary, Checksum (backport #2125) Deprecate compact serialization of Binary, HexBinary, Checksum (backport #2125) Apr 25, 2024
@uint uint force-pushed the mergify/bp/release/2.0/pr-2125 branch from 7d3818c to 686fb6e Compare April 25, 2024 09:30
@uint
changelog
2e3aa66 
(cherry picked from commit b8da044)
@uint
elaborate on panic msg for Binary/HexBinary
301b020 
(cherry picked from commit fea397c)
@uint
elaborate on panic msg for Checksum
686fb6e 
(cherry picked from commit 82464e5)
@uint uint merged commit 5aef3b7 into release/2.0 Apr 25, 2024
28 of 29 checks passed
@uint uint deleted the mergify/bp/release/2.0/pr-2125 branch April 25, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@chipshort chipshort Awaiting requested review from chipshort

Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @uint